⚡

// Skill profile

Phoenix Code Review

Name: Phoenix Code Review
Author: anderskev

name: phoenix-code-review

by anderskev · published 2026-04-01

开发工具数据处理

Total installs

Stars

★ 0

Last updated

2026-04

// Install command

$ claw add gh:anderskev/anderskev-phoenix-code-review

View on GitHub

// Full documentation

---

name: phoenix-code-review

description: Reviews Phoenix code for controller patterns, context boundaries, routing, and plugs. Use when reviewing Phoenix apps, checking controllers, routers, or context modules.

---

# Phoenix Code Review

Quick Reference

| Issue Type | Reference |

|------------|-----------|

| Bounded contexts, Ecto integration | [references/contexts.md](references/contexts.md) |

| Actions, params, error handling | [references/controllers.md](references/controllers.md) |

| Pipelines, scopes, verified routes | [references/routing.md](references/routing.md) |

| Custom plugs, authentication | [references/plugs.md](references/plugs.md) |

Review Checklist

Controllers

[ ] Business logic in contexts, not controllers

[ ] Controllers return proper HTTP status codes

[ ] Action clauses handle all expected patterns

[ ] Fallback controllers handle errors consistently

Contexts

[ ] Contexts are bounded by domain, not technical layer

[ ] Public functions have clear, domain-focused names

[ ] Changesets validate all user input

[ ] No Ecto queries in controllers

Routing

[ ] Verified routes (~p sigil) used, not string paths

[ ] Pipelines group related plugs

[ ] Resources use only needed actions

[ ] Scopes group related routes

Plugs

[ ] Authentication/authorization via plugs

[ ] Plugs are composable and single-purpose

[ ] Halt called after sending response in plugs

JSON APIs

[ ] Proper content negotiation

[ ] Consistent error response format

[ ] Pagination for list endpoints

Valid Patterns (Do NOT Flag)

**Controller calling multiple contexts** - Valid for orchestration

**Inline Ecto query in context** - Context owns its data access

**Using `action_fallback`** - Centralized error handling pattern

**Multiple pipelines per route** - Composition is intentional

**`Plug.Conn.halt/1` without send** - May be handled by fallback

Context-Sensitive Rules

| Issue | Flag ONLY IF |

|-------|--------------|

| Missing changeset validation | Field accepts user input AND no validation exists |

| Controller too large | More than 7 actions OR actions > 20 lines |

| Missing authorization | Route is not public AND no auth plug in pipeline |

Before Submitting Findings

Load and follow [review-verification-protocol](../../../../skills/review-verification-protocol/SKILL.md) before reporting any issue.

// Comments

// Related skills

More tools from the same signal band

Order food/drinks (点餐) on an Android device paired as an OpenClaw node. Uses in-app menu and cart; add goods, view cart, submit order (demo, no real payment).

Sign plugins, rotate agent credentials without losing identity, and publicly attest to plugin behavior with verifiable claims and authenticated transfers.

The philosophical layer for AI agents. Maps behavior to Spinoza's 48 affects, calculates persistence scores, and generates geometric self-reports. Give your...

日历管理数据处理

1 installs★ 0